[ 3.5.y.z extended stable ] Patch "sched/debug: Fix sd->*_idx limit range avoiding overflow" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Wed May 29 16:28:54 UTC 2013


This is a note to let you know that I have just added a patch titled

    sched/debug: Fix sd->*_idx limit range avoiding overflow

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From 37b5925faa3c5ee3b373d860e1af5e10a7c082dd Mon Sep 17 00:00:00 2001
From: libin <huawei.libin at huawei.com>
Date: Mon, 8 Apr 2013 14:39:12 +0800
Subject: [PATCH] sched/debug: Fix sd->*_idx limit range avoiding overflow

commit fd9b86d37a600488dbd80fe60cca46b822bff1cd upstream.

Commit 201c373e8e ("sched/debug: Limit sd->*_idx range on
sysctl") was an incomplete bug fix.

This patch fixes sd->*_idx limit range to [0 ~ CPU_LOAD_IDX_MAX-1]
avoiding array overflow caused by setting sd->*_idx to CPU_LOAD_IDX_MAX
on sysctl.

Signed-off-by: Libin <huawei.libin at huawei.com>
Cc: <jiang.liu at huawei.com>
Cc: <guohanjun at huawei.com>
Cc: Peter Zijlstra <peterz at infradead.org>
Link: http://lkml.kernel.org/r/51626610.2040607@huawei.com
Signed-off-by: Ingo Molnar <mingo at kernel.org>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index e22a1f0..89e8c2c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5435,7 +5435,7 @@ static void sd_free_ctl_entry(struct ctl_table **tablep)
 }

 static int min_load_idx = 0;
-static int max_load_idx = CPU_LOAD_IDX_MAX;
+static int max_load_idx = CPU_LOAD_IDX_MAX-1;

 static void
 set_table_entry(struct ctl_table *entry,
--
1.8.1.2





More information about the kernel-team mailing list