[ 3.5.y.z extended stable ] Patch "avr32: fix relocation check for signed 18-bit offset" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Tue May 28 09:51:05 UTC 2013


This is a note to let you know that I have just added a patch titled

    avr32: fix relocation check for signed 18-bit offset

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From c900b688ffd503fa40001410394bcb50b2b83631 Mon Sep 17 00:00:00 2001
From: Hans-Christian Egtvedt <egtvedt at samfundet.no>
Date: Mon, 13 May 2013 22:22:10 +0200
Subject: [PATCH] avr32: fix relocation check for signed 18-bit offset

commit e68c636d88db3fda74e664ecb1a213ae0d50a7d8 upstream.

Caught by static code analysis by David.

Reported-by: David Binderman <dcb314 at hotmail.com>
Signed-off-by: Hans-Christian Egtvedt <egtvedt at samfundet.no>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 arch/avr32/kernel/module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/kernel/module.c b/arch/avr32/kernel/module.c
index 596f730..2c94129 100644
--- a/arch/avr32/kernel/module.c
+++ b/arch/avr32/kernel/module.c
@@ -264,7 +264,7 @@ int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab,
 			break;
 		case R_AVR32_GOT18SW:
 			if ((relocation & 0xfffe0003) != 0
-			    && (relocation & 0xfffc0003) != 0xffff0000)
+			    && (relocation & 0xfffc0000) != 0xfffc0000)
 				return reloc_overflow(module, "R_AVR32_GOT18SW",
 						     relocation);
 			relocation >>= 2;
--
1.8.1.2





More information about the kernel-team mailing list