[PATCH 2/2][nexus4] UBUNTU: remove CONFIG_NO_ERROR_ON_MISMATCH check

Andy Whitcroft apw at canonical.com
Wed May 15 15:46:18 UTC 2013


On Tue, May 14, 2013 at 03:58:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Commit 3f2bc4d6eb5a4fada842462ba22bb6bbb41d00c7 added in a
> CONFIG_NO_ERROR_ON_MISMATCH which deviates from the normal Ubuntu
> configs and makes this kernel more pedantic than normal Ubuntu
> kernels.  This breaks DKMS builds such as lttng-modules which may
> have section mismatch warnings which otherwise are trival issues and
> won't actually cause breakage.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  scripts/Makefile.modpost |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index c1bc458..08dce14 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -80,7 +80,6 @@ modpost = scripts/mod/modpost                    \
>   $(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e %,$(KBUILD_EXTRA_SYMBOLS))) \
>   $(if $(KBUILD_EXTMOD),-o $(modulesymfile))      \
>   $(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S)      \
> - $(if $(CONFIG_NO_ERROR_ON_MISMATCH),,-E)	 \

Is this not just a configuration option in the kernel config?  Could we
not have just changed that rather than changing the code?

-apw




More information about the kernel-team mailing list