[PATCH 106/118] fs/fscache/stats.c: fix memory leak

Luis Henriques luis.henriques at canonical.com
Tue May 7 13:39:12 UTC 2013


3.5.7.12 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Anurup m <anurup.m at huawei.com>

commit ec686c9239b4d472052a271c505d04dae84214cc upstream.

There is a kernel memory leak observed when the proc file
/proc/fs/fscache/stats is read.

The reason is that in fscache_stats_open, single_open is called and the
respective release function is not called during release.  Hence fix
with correct release function - single_release().

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=57101

Signed-off-by: Anurup m <anurup.m at huawei.com>
Cc: shyju pv <shyju.pv at huawei.com>
Cc: Sanil kumar <sanil.kumar at huawei.com>
Cc: Nataraj m <nataraj.m at huawei.com>
Cc: Li Zefan <lizefan at huawei.com>
Cc: David Howells <dhowells at redhat.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 fs/fscache/stats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fscache/stats.c b/fs/fscache/stats.c
index 4765190..73c0bd7 100644
--- a/fs/fscache/stats.c
+++ b/fs/fscache/stats.c
@@ -276,5 +276,5 @@ const struct file_operations fscache_stats_fops = {
 	.open		= fscache_stats_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release	= seq_release,
+	.release        = single_release,
 };
-- 
1.8.1.2





More information about the kernel-team mailing list