ACK: [PATCH Raring SRU] xhci: Don't warn on empty ring for suspended devices.

Luis Henriques luis.henriques at canonical.com
Tue May 7 09:24:49 UTC 2013


On Mon, May 06, 2013 at 09:38:28AM +0000, Zhang, Xiong Y wrote:
> OSVs may want to backport this patch, to avoid log spam when USB devices are suspended.
> 
> commit a83d6755814e4614ba77e15d82796af0f695c6b8
> Author: Sarah Sharp <sarah.a.sharp at linux.intel.com>
> Date:   Mon Mar 18 10:19:51 2013 -0700
> 
>     xhci: Don't warn on empty ring for suspended devices.
> 
>     When a device attached to the roothub is suspended, the endpoint rings
>     are stopped.  The host may generate a completion event with the
>     completion code set to 'Stopped' or 'Stopped Invalid' when the ring is
>     halted.  The current xHCI code prints a warning in that case, which can
>     be really annoying if the USB device is coming into and out of suspend.
> 
> Remove the unnecessary warning.
> 
> 
> thanks

> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Seems to make sense for raring and, eventually, for Quantal as well.
(I'll revisit this patch for the 3.5.y stable later so that it will
hit Quantal from a stable update.)

Cheers,
--
Luis




More information about the kernel-team mailing list