[ 3.5.y.z extended stable ] Patch "usb: gadget: ffs: fix enable multiple instances" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Mon Mar 25 18:02:39 UTC 2013

This is a note to let you know that I have just added a patch titled

    usb: gadget: ffs: fix enable multiple instances

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



>From e7cfd9e1458288981161476cf14dec7e0bdf22ba Mon Sep 17 00:00:00 2001
From: Andrzej Pietrasiewicz <andrzej.p at samsung.com>
Date: Mon, 11 Mar 2013 16:32:14 +0100
Subject: [PATCH] usb: gadget: ffs: fix enable multiple instances

commit 3416905ba058e43112ad7b1b4859797f027f5a07 upstream.

This patch fixes an "off-by-one" bug found in
581791f (FunctionFS: enable multiple functions).

During gfs_bind/gfs_unbind the functionfs_bind/functionfs_unbind should be
called for every functionfs instance. With the "i" pre-decremented they
were not called for the zeroth instance.

Acked-by: Michal Nazarewicz <mina86 at mina86.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p at samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>

[ balbi at ti.com : added offending commit's subject ]

Signed-off-by: Felipe Balbi <balbi at ti.com>
[ luis: adjust context ]
Luis Henriques <luis.henriques at canonical.com>
 drivers/usb/gadget/g_ffs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
index d3ace90..919177b 100644
--- a/drivers/usb/gadget/g_ffs.c
+++ b/drivers/usb/gadget/g_ffs.c
@@ -358,7 +358,7 @@ static int gfs_bind(struct usb_composite_dev *cdev)
 	if (unlikely(ret < 0))
 		goto error;

-	for (i = func_num; --i; ) {
+	for (i = func_num; i--; ) {
 		ret = functionfs_bind(ffs_tab[i].ffs_data, cdev);
 		if (unlikely(ret < 0)) {
 			while (++i < func_num)
@@ -413,7 +413,7 @@ static int gfs_unbind(struct usb_composite_dev *cdev)
 	gfs_ether_setup = false;

-	for (i = func_num; --i; )
+	for (i = func_num; i--; )
 		if (ffs_tab[i].ffs_data)


More information about the kernel-team mailing list