[PATCH 07/88] btrfs: Init io_lock after cloning btrfs device struct

Luis Henriques luis.henriques at canonical.com
Thu Mar 14 10:35:00 UTC 2013 -stable review patch.  If anyone has any objections, please let me know.


From: Thomas Gleixner <tglx at linutronix.de>

commit 1cba0cdf5e4dbcd9e5fa5b54d7a028e55e2ca057 upstream.

__btrfs_close_devices() clones btrfs device structs with
memcpy(). Some of the fields in the clone are reinitialized, but it's
missing to init io_lock. In mainline this goes unnoticed, but on RT it
leaves the plist pointing to the original about to be freed lock

Initialize io_lock after cloning, so no references to the original
struct are left.

Reported-and-tested-by: Mike Galbraith <efault at gmx.de>
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
Signed-off-by: Chris Mason <chris.mason at fusionio.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 fs/btrfs/volumes.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 037e0bb..2208f0f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -575,6 +575,7 @@ static int __btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
 		new_device->writeable = 0;
 		new_device->in_fs_metadata = 0;
 		new_device->can_discard = 0;
+		spin_lock_init(&new_device->io_lock);
 		list_replace_rcu(&device->dev_list, &new_device->dev_list);
 		call_rcu(&device->rcu, free_device);

More information about the kernel-team mailing list