[Precise][Quantal][Raring][SRU][PATCH] UBUNTU: SAUCE ncpfs: fix rmdir returns Device or resource

Dave Chiluk chiluk at canonical.com
Wed Jun 5 21:57:42 UTC 2013


SRU Justification:

Impact: Directories can not be removed from ncpfs shares.
Fix: ncpfs was checking to see if a dentry was hashed before continuing to process the removal. However because of 1d2ef5901483004d74947bbf78d5146c24038fe7 that check will check will always fail.  The fix is to remove this check as it is no longer a valid way of determining if a folder is in use.  Additionally removing this check brings ncpfs more in line with the behavior of other network filesystems such as nfs or cifs
Testcase: mount ncpfs share
 # /usr/bin/ncpmount -S 192.168.1.56 -A 192.168.1.56 -U .root.O_TEST -V /SYS -y utf8 -p utf8 -m -d 0755 -f 0644 /mnt/ncp -u root -g root -N nfs -o tcp
 # cd /mnt/ncp
 # mkdir /mnt/ncp/pants
 # rmdir /mnt/ncp/pants
 # mkdir /mnt/ncp/my/pants
 # rm -rf /mnt/ncp/my

Other: This patch has been submitted upstream, and has been acked by the maintainer of the code.  However as ncpfs is not in active development or maintenance it may take some time to get actually accepted upstream.

For now I'm submitting this as a SAUCE patch as I have heard no negative feedback, and it does resolve the issue for a number of users.  I will continue to push on upstream to accept this.





More information about the kernel-team mailing list