[ 3.5.y.z extended stable ] Patch "pch_uart: Add uart_clk selection for the MinnowBoard" has been added to staging queue

[Luis Henriques]

Darren Hart <dvhart at linux.intel.com> writes:

> On Fri, 2013-07-05 at 12:01 +0100, Luis Henriques wrote:
>> This is a note to let you know that I have just added a patch titled
>> 
>>     pch_uart: Add uart_clk selection for the MinnowBoard
>> 
>> to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
>> which can be found at:
>> 
>>  http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue
>> 
>> If you, or anyone else, feels it should not be added to this tree, please 
>> reply to this email.
>
> Hi Luis,
>
> Thanks for pulling this in. I wonder of the value of pulling support for
> an EFI-only (no legacy BIOS) board back into the 3.5 kernel. My
> understanding is that strong EFI support really landed in 3.8. Again, I
> don't object, but there is the concern of setting an expectation that it
> will work with 3.5 when there is likely some missing EFI work.
>
> That said, there has been a lot of interest in other types of firmware,
> so perhaps this is reasonable to prepare the way for those. Just
> something to consider.
>
> --
> Darren
>

Hi Darren,

Thank you for your feedback.  I understand there's probably no benefit
pulling this into 3.5 kernels, so I just dropped it from the queue.

Cheers,
-- 
Luis


>> 
>> For more information about the 3.5.y.z tree, see
>> https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
>> 
>> Thanks.
>> -Luis
>> 
>> ------
>> 
>> From 7df5d07c11537898a09dbd6dcf653daa6d78ad62 Mon Sep 17 00:00:00 2001
>> From: Darren Hart <dvhart at linux.intel.com>
>> Date: Tue, 25 Jun 2013 18:53:22 -0700
>> Subject: [PATCH] pch_uart: Add uart_clk selection for the MinnowBoard
>> 
>> commit 29692d05647cb7ecea56242241f77291d5624b95 upstream.
>> 
>> Use DMI_BOARD_NAME to determine if we are running on a MinnowBoard and
>> set the uart clock to 50MHz if so. This removes the need to pass the
>> user_uartclk to the kernel at boot time.
>> 
>> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
>> Cc: Jiri Slaby <jslaby at suse.cz>
>> Cc: "H. Peter Anvin" <hpa at zytor.com>
>> Cc: Peter Waskiewicz <peter.p.waskiewicz.jr at intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>> Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
>> ---
>>  drivers/tty/serial/pch_uart.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
>> index 4798e94..1b18ba2 100644
>> --- a/drivers/tty/serial/pch_uart.c
>> +++ b/drivers/tty/serial/pch_uart.c
>> @@ -214,6 +214,7 @@ enum {
>>  #define FRI2_64_UARTCLK  64000000 /*  64.0000 MHz */
>>  #define FRI2_48_UARTCLK  48000000 /*  48.0000 MHz */
>>  #define NTC1_UARTCLK     64000000 /*  64.0000 MHz */
>> +#define MINNOW_UARTCLK   50000000 /*  50.0000 MHz */
>> 
>>  struct pch_uart_buffer {
>>  	unsigned char *buf;
>> @@ -395,6 +396,10 @@ static int pch_uart_get_uartclk(void)
>>  		    strstr(cmp, "nanoETXexpress-TT")))
>>  		return NTC1_UARTCLK;
>> 
>> +	cmp = dmi_get_system_info(DMI_BOARD_NAME);
>> +	if (cmp && strstr(cmp, "MinnowBoard"))
>> +		return MINNOW_UARTCLK;
>> +
>>  	return DEFAULT_UARTCLK;
>>  }
>> 
>> --
>> 1.8.1.2
>>