[Acked w/ cmt] [Raring SRU] Add tg3 driver support for Broadcom 5725 (NIC)

[Stefan Bader]

On 07/04/2013 10:12 AM, Andy Whitcroft wrote:
> On Wed, Jul 03, 2013 at 10:24:43PM +0200, Stefan Bader wrote:
>> This set of patches adds support for a new NIC version to the tg3
>> ethernet driver. It has been tested sucessfully and all changes
>> only add functionality in case of the new HW ID being detected.
>>
>> We would need this to go into a Raring kernel early enough to be
>> part of 12.04.3 to have installer support in the HWE kernel stack
>> in Precise.
>>
>> BugLink: http://bugs.launchpad.net/bugs/1178899
>
> This is one of those difficult calls.  The patchset seems sane enough
> but it is not exactly teeny.  It seems that all of the code here is
> model specific but it is far from possible to tell if it is all
> correctly aligned to the new model.
>

Yes it does look a bit scary at first. Though I went over the first two patches 
(which contain the majority of changes) and at least to my eye everything was 
done properly and does something different only when that new chipset id is 
detected.
Of course more testing is always a good thing. Just happen to realize that this 
puny netbook of mine actually has a tg3 Broadcom in, though only an old 5906 as 
it reports itself. At least that one is running with Saucy and works.

> If we are able to test well with other non-new tg3 chipsets then this
> seems like something which would be possible to apply.
>
> Based on having some sensible regression testing:
>
> Acked-by: Andy Whitcroft <apw at canonical.com>
>
> I have also checked saucy and it seems all of this was present by
> v3.10-rc3 so I think we are good there.  Perhaps some early testing of
> tg3 there would help as well.
>
> -apw
>