Applied: [Quantal] [PATCH 0/3] Prevent samsung-laptop bricking when using UEFI

Brad Figg brad.figg at canonical.com
Thu Jan 31 22:23:37 UTC 2013


On 01/31/2013 11:59 AM, Brad Figg wrote:
> SRU Justification:
> 
> Impact:
> With the existing code there is still the chance that the samsung-laptop driver can run if the given system is booting a 32-bit kernel with 64-bit EFI firmware (or vice versa). This
> can lead to a system that is "bricked" and can not be recovered.
> 
> Fix:
> First, we will need to revert the existing commit we have for the samsung-laptop/EFI
> issue:
>     2fe5d5c565ad7ed16d5a01eee1f03dfd91dfa6a0 (Quantal tree)
> 
> Then we need to cherry-pick/backport the following two commits from Linus' tree
>     83e68189745ad931c2afd45d8ee3303929233e7f
>     e0094244e41c4d0c7ad69920681972fc45d8ce34
> 
> 
> The following patches do exactly that, they revert the previous Ubuntu Sauce
> patch to the samsung-laptop driver, backport the "Make 'efi_enabled' a function"
> commit and cherry-pick a new commit to the samsung-laptop driver.
> 
> Brad Figg (1):
>   Revert "UBUNTU: SAUCE: samsung-laptop: disable in UEFI mode"
> 
> Matt Fleming (2):
>   efi: Make 'efi_enabled' a function to query EFI facilities
>   samsung-laptop: Disable on EFI hardware
> 
>  arch/x86/include/asm/efi.h             |    1 +
>  arch/x86/kernel/reboot.c               |    2 +-
>  arch/x86/kernel/setup.c                |   28 ++++++++--------
>  arch/x86/platform/efi/efi.c            |   57 +++++++++++++++++++-------------
>  drivers/acpi/osl.c                     |    2 +-
>  drivers/firmware/dmi_scan.c            |    2 +-
>  drivers/firmware/efivars.c             |    4 +--
>  drivers/firmware/iscsi_ibft_find.c     |    2 +-
>  drivers/gpu/drm/radeon/radeon_device.c |    3 +-
>  drivers/platform/x86/ibm_rtl.c         |    2 +-
>  drivers/platform/x86/samsung-laptop.c  |    4 +--
>  drivers/scsi/isci/init.c               |    2 +-
>  include/linux/efi.h                    |   24 ++++++++++----
>  init/main.c                            |    4 +--
>  14 files changed, 81 insertions(+), 56 deletions(-)
> 


-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list