Ack (with comments): [Quantal][Pull-Request v2] Add realtek pcie card reader driver to fix #1057089

[Brad Figg]

On 01/29/2013 10:51 PM, Adam Lee wrote:
> BugLink: http://launchpad.net/bugs/1057089
> 
> The following changes since commit 7ec14257dfb888d45048afdab6f6c5d1d3aeb4cb:
> 
>   UBUNTU: drivers/mfd: Add realtek pcie card reader driver (2013-01-30 14:29:14 +0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/adamlee/ubuntu-quantal.git master
> 
> for you to fetch changes up to 62a01e6237605f6b73add92a9422270040a22723:
> 
>   UBUNTU: [Config] Enable RTSX_PCI modules (2013-01-30 14:31:28 +0800)
> 
> ----------------------------------------------------------------
> Adam Lee (1):
>       UBUNTU: [Config] Enable RTSX_PCI modules
> 
> Wei WANG (6):
>       UBUNTU: mmc: Add realtek pcie sdmmc host driver
>       UBUNTU: mmc: rtsx: Remove a duplicate command in sd_rw_multi
>       UBUNTU: mmc: rtsx: Configure SD_CFG2 register in sd_rw_multi
>       UBUNTU: mmc: rtsx: Explicitely include slab.h in rtsx_pci_sdmmc.c
>       UBUNTU: drivers/memstick: Add realtek pcie memstick host driver
>       UBUNTU: mfd: rtsx: Fix oops when rtsx_pci_sdmmc is not probed
> 
>  debian.master/config/config.common.ubuntu |    3 +
>  drivers/memstick/host/Kconfig             |   10 +
>  drivers/memstick/host/Makefile            |    1 +
>  drivers/memstick/host/rtsx_pci_ms.c       |  641 ++++++++++++++
>  drivers/mfd/rtsx_pcr.c                    |    4 +-
>  drivers/mmc/host/Kconfig                  |    7 +
>  drivers/mmc/host/Makefile                 |    2 +
>  drivers/mmc/host/rtsx_pci_sdmmc.c         | 1326 +++++++++++++++++++++++++++++
>  8 files changed, 1992 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/memstick/host/rtsx_pci_ms.c
>  create mode 100644 drivers/mmc/host/rtsx_pci_sdmmc.c
> 

These look fine. I only had problems applying the [Config] Enable RTSX_PCI modules
patch. I assume this is because you did all your changes on the master branch and
not the master-next branch. Here are my two comments:

1. Since these are all upstream commits that we are pulling in you do not need
   the "UBUNTU:" decoration on the commit. I know this is some of the more
   confusing parts of our submission rules.

2. Always work on the master-next branch of a updated repo. That is where your
   patches will be committed. Commits are moved onto the master branch when
   we are releasing them.

Brad
-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com