[Precise][Pull-Request] Add realtek pcie card reader driver to fix #1057089

[Adam Lee]

Hi, Luis,

On Mon, Jan 28, 2013 at 02:40:14PM +0000, Luis Henriques wrote:
> Hi Adam,
> 
> On Mon, Jan 28, 2013 at 03:03:21PM +0800, Adam Lee wrote:
> > BugLink: http://launchpad.net/bugs/1057089
> > 
> > Backported the upstream realtek pcie card reader driver.
> 
> I've took a quick look at these patches and I found a couple of issues:
> 
> Commits don't identify their origin -- are they upstream cherry-picks?
> If so, they should contain the "(cherry-picked from commit XXXXXX)"
> entry.  Also, they don't contain the BugLink.

Oops, sorry.

> I've tried to find the corresponding upstream commits and there's at
> least one I couldn't find anywhere:
> 
>  commit 260b2cae1daca5640c0efcb9c93ccfc10b24b34e
>  "MFD:rtsx:Avoid kernel panic if rtsx_pci_sdmmc not probed"
> 
> If this is not upstream, it should also contain 'UBUNTU: SAUCE' and an
> indication of its source.

This is not from upstream, but from LKML. This patch fixes a panic
issue, I think it should be merged in even it's not merged by upstream
mainline yet.
 
> Finally, there are some changes made from the original upstream commits
> that are difficult to understand and that may cause maintenance
> problems.  For example, your commit
> 0b3359b47ca714c9bb6f617e495138b298093038 contains an extra function
> (rtsx_pci_switch_output_voltage) that is not in the corresponding
> upstream commit; however, there's another function in upstream commit
> 2c94b6452cc6de582584f21066cc5e36d9530c59 (your commit
> 7c6e81b68539422a1dee4f602f6a62ab402bdb01) that has function
> sd_change_bank_voltage.  What's the rational behind this?  Can't we get
> some clean cherry-picks?

No, we can't get clean cherry-picks, this driver uses some very new
features which 3.2 or 3.5 don't have. I signed off if the commit is
changed by me.

It uses mod_delayed_work(), new mmc voltage related feature
(upstream commit 55c4665ea0a42fd6427826bfce96eb4b0389262a). I need to do
some changes, or it won't work. PS, most of these changes comes from the
vendor(Realtek). 

This is the first bug I submitting patches to our kernel tree(I came to
Canonical this month), sorry for the trouble. Do I need modify the
commit messages and submit them again?

-- 
Regards,
Adam Lee
Hardware Enablement
IRC: adam8157 @ #china #hwe