NAK: [PATCH Precise LTS 1/2] add Realtek 5229 card reader staging driver
Tim Gardner
tim.gardner at canonical.com
Thu Jan 17 13:23:57 UTC 2013
On 01/16/2013 07:52 PM, Adam Lee wrote:
> BugLink: http://launchpad.net/bugs/1057089
>
> Realtek pushed a non-staging version into upstream(
> 67d16a4686c9b94c8f52a66afe7521909aeb75b4), but it crashes with ThinkPad
> E430 and E530, so I ported this official staging driver to our kernel.
>
> Tested with ThinkPad E430, the card reader works well.
>
> Cc: Ming Lei <ming.lei at canonical.com>
> Signed-off-by: Adam Lee <adam.lee at canonical.com>
> ---
Perhaps you should spend a little time figuring out _why_ this driver
crashes on a Thinkpad. I'm not going to merge a driver that has been
essentially abandoned, e.g., moved out of staging. I want the real thing
that comes with upstream stable and security updates. Furthermore, I
want a proper pull request for a patch of this size.
rtg
--
Tim Gardner tim.gardner at canonical.com
More information about the kernel-team
mailing list