[PATCH 69/81] bridge: Pull ip header into skb->data before looking into ip header.

Herton Ronaldo Krzesinski herton.krzesinski at canonical.com
Tue Feb 19 18:49:32 UTC 2013 -stable review patch.  If anyone has any objections, please let me know.


From: Sarveshwar Bandi <sarveshwar.bandi at emulex.com>

commit 6caab7b0544e83e6c160b5e80f5a4a7dd69545c7 upstream.

If lower layer driver leaves the ip header in the skb fragment, it needs to
be first pulled into skb->data before inspecting ip header length or ip version

Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi at emulex.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
 net/bridge/br_netfilter.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index e41456b..ab52468 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -256,6 +256,9 @@ static int br_parse_ip_options(struct sk_buff *skb)
 	struct net_device *dev = skb->dev;
 	u32 len;
+	if (!pskb_may_pull(skb, sizeof(struct iphdr)))
+		goto inhdr_error;
 	iph = ip_hdr(skb);
 	opt = &(IPCB(skb)->opt);

More information about the kernel-team mailing list