[PATCH 44/81] ipv6: fix the noflags test in addrconf_get_prefix_route
Herton Ronaldo Krzesinski
herton.krzesinski at canonical.com
Tue Feb 19 18:49:07 UTC 2013
3.5.7.6 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Romain Kuntz <r.kuntz at ipflavors.com>
commit 85da53bf1c336bb07ac038fb951403ab0478d2c5 upstream.
The tests on the flags in addrconf_get_prefix_route() does no make
much sense: the 'noflags' parameter contains the set of flags that
must not match with the route flags, so the test must be done
against 'noflags', and not against 'flags'.
Signed-off-by: Romain Kuntz <r.kuntz at ipflavors.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji at linux-ipv6.org>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 0808ad5..fc9ac78 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1741,7 +1741,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx,
continue;
if ((rt->rt6i_flags & flags) != flags)
continue;
- if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0))
+ if ((rt->rt6i_flags & noflags) != 0)
continue;
dst_hold(&rt->dst);
break;
--
1.7.9.5
More information about the kernel-team
mailing list