[3.11.y.z extended stable] Patch "ioatdma: Fix bug in selftest after removal of DMA_MEMSET." has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Thu Dec 5 11:20:20 UTC 2013


This is a note to let you know that I have just added a patch titled

    ioatdma: Fix bug in selftest after removal of DMA_MEMSET.

to the linux-3.11.y-queue branch of the 3.11.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.11.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.11.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From 8a3bbd0e0ea90ecef33022879d74786a28eed894 Mon Sep 17 00:00:00 2001
From: Dave Jiang <dave.jiang at intel.com>
Date: Wed, 6 Nov 2013 08:50:09 -0700
Subject: ioatdma: Fix bug in selftest after removal of DMA_MEMSET.

commit ac7d631f7d9f9e4e6116c4a72b6308067d0a2226 upstream.

Commit 48a9db4 (3.11) removed the memset op in the xor selftest for ioatdma.
The issue is that with the removal of that op, it never replaced the memset
with a CPU memset. The memory being operated on is expected to be zeroes but
was not. This is causing the xor selftest to fail.

Signed-off-by: Dave Jiang <dave.jiang at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 drivers/dma/ioat/dma_v3.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index b642e03..dc4191c 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -1545,6 +1545,8 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device)
 		goto free_resources;
 	}

+	memset(page_address(dest), 0, PAGE_SIZE);
+
 	/* test for non-zero parity sum */
 	op = IOAT_OP_XOR_VAL;

--
1.8.3.2





More information about the kernel-team mailing list