[ 3.5.y.z extended stable ] Patch "nilfs2: remove double bio_put() in nilfs_end_bio_write() for" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Thu Aug 29 09:32:40 UTC 2013


This is a note to let you know that I have just added a patch titled

    nilfs2: remove double bio_put() in nilfs_end_bio_write() for

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From 78b93f0e3a9664fc6c740a130d409e580e839bf8 Mon Sep 17 00:00:00 2001
From: Vyacheslav Dubeyko <slava at dubeyko.com>
Date: Thu, 22 Aug 2013 16:35:44 -0700
Subject: [PATCH] nilfs2: remove double bio_put() in nilfs_end_bio_write() for
 BIO_EOPNOTSUPP error

commit 2df37a19c686c2d7c4e9b4ce1505b5141e3e5552 upstream.

Remove double call of bio_put() in nilfs_end_bio_write() for the case of
BIO_EOPNOTSUPP error detection.  The issue was found by Dan Carpenter
and he suggests first version of the fix too.

Signed-off-by: Vyacheslav Dubeyko <slava at dubeyko.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke at lab.ntt.co.jp>
Tested-by: Ryusuke Konishi <konishi.ryusuke at lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 fs/nilfs2/segbuf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index dc9a913..5bacf46 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
@@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err)

 	if (err == -EOPNOTSUPP) {
 		set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
-		bio_put(bio);
-		/* to be detected by submit_seg_bio() */
+		/* to be detected by nilfs_segbuf_submit_bio() */
 	}

 	if (!uptodate)
--
1.8.3.2





More information about the kernel-team mailing list