ACK: [Quantal][PATCH] efivars: explicitly calculate length of VariableName

Hui Wang hui.wang at canonical.com
Tue Aug 27 10:17:22 UTC 2013


On 08/27/2013 06:12 PM, Luis Henriques wrote:
> Hui Wang <hui.wang at canonical.com> writes:
>
>> From: Matt Fleming <matt.fleming at intel.com>
>>
>> BugLink: https://bugs.launchpad.net/hwe-sutton/+bug/1211725
>>
>> It's not wise to assume VariableNameSize represents the length of
>> VariableName, as not all firmware updates VariableNameSize in the same
[snip]
>>   						  variable_name_size,
>>   						  variable_name,
>> -- 
>> 1.8.1.2
> [ Just a minor comment: you used 'cherry picked from commit ...'
>    instead of 'back ported from commit ...' ]
>
> The backport seems to make sense to me: you just dropped the chunk
> related with the workqueue code (added by a93bc0c "efi_pstore:
> Introducing workqueue updating sysfs").  This is also consistent with
> the backport used by Greg for the 3.8 kernel.
>
> Since I've backported to 3.5 stable kernel lots of EFI-related
> commits, I'll also queue this one for next release.
>
> Cheers,
Got it, thanks.

Hui.




More information about the kernel-team mailing list