[ 3.5.y.z extended stable ] Patch "serial: mxs: fix buffer overflow" has been added to staging queue
Luis Henriques
luis.henriques at canonical.com
Fri Aug 16 09:31:19 UTC 2013
This is a note to let you know that I have just added a patch titled
serial: mxs: fix buffer overflow
to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue
If you, or anyone else, feels it should not be added to this tree, please
reply to this email.
For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Luis
------
>From a9f8ad3b3c8291e8e26c8ddadf5633097add09fa Mon Sep 17 00:00:00 2001
From: Wolfram Sang <wsa at the-dreams.de>
Date: Fri, 19 Apr 2013 21:12:17 +0200
Subject: [PATCH] serial: mxs: fix buffer overflow
commit 4829e7650f8a40645e4e32b26a37fb833a5e75f0 upstream.
SMATCH correctly found an off-by-one error:
drivers/tty/serial/mxs-auart.c:889 auart_console_write() error: buffer overflow 'auart_port' 5 <= 5
Signed-off-by: Wolfram Sang <wsa at the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Kamal Mostafa <kamal at canonical.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
drivers/tty/serial/mxs-auart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 64565f8..5ceeed8 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -547,7 +547,7 @@ auart_console_write(struct console *co, const char *str, unsigned int count)
unsigned int old_ctrl0, old_ctrl2;
unsigned int to = 20000;
- if (co->index > MXS_AUART_PORTS || co->index < 0)
+ if (co->index >= MXS_AUART_PORTS || co->index < 0)
return;
s = auart_port[co->index];
--
1.8.3.2
More information about the kernel-team
mailing list