[PATCH] make ektf3k driver report non-MT events too

[Matt Whitlock]

On Thursday, 8 August 2013, at 1:49 pm, Seth Forshee wrote:
> On Wed, Aug 07, 2013 at 01:51:12PM -0400, Matt Whitlock wrote:
> > Joseph Salisbury requested that I submit this patch to the Ubuntu Kernel Team mailing list for review.
> > 
> > > This patch resolves a shortcoming of the ektf3k driver. Previously, the
> > > driver was reporting only multi-touch events. xf86-input-evdev 2.7.3
> > > crashes upon receiving input events from [that] driver, and 2.8.1 simply
> > > ignores the input device altogether as a workaround for the crash.
> > > 
> > > This patch adds single-touch ABS_X, ABS_Y, and ABS_PRESSURE axes, as well as
> > > the BTN_TOUCH key. Only the first finger touching reports on these
> > > single-touch axes (while continuing to report on the multi-touch axes);
> > > additional fingers report only on the multi-touch axes.
> > > 
> > > I have tested this patch on a Nexus 7 running X.org server 1.13.4 and
> > > xf86-input-evdev 2.8.1. Without the patch, evdev ignores all input from the
> > > touchscreen. With the patch, evdev generates mouse events in response to
> > > touches, as one would expect.
> > 
> > https://bugs.launchpad.net/ubuntu/+source/linux-grouper/+bug/1209049
> 
> input_mt_report_pointer_emulation() exists for exactly this purpose, so
> it would be preferable to use that instead.

Thanks for the pointer, Seth.  I am not too familiar with the kernel input layer.  I've adjusted my patch and confirmed that it still works as intended.  See the Launchpad bug or the attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ektf3k-pointeremu.patch
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20130809/017f9787/attachment.bin>