NAK: [precise lts-backports-quantal][PATCH] UBUNTU: Add proper Provides fields in flavour-control.

[Tim Gardner]

On 08/01/2013 04:37 PM, Chris J Arges wrote:
> BugLink: http://bugs.ubuntu.com/bugs/1207326
>
> The lts-backport-quantal kernel does not have the proper Provides files.
> This adds Provides fields for linux-image, linux-headers, and linux-debug.
> In addition there is a suggests for linux-headers-PKGVER-ABINUM-FLAVOUR.
> This is working properly other backport kernels and non-backport kernels.
>
> Signed-off-by: Chris J Arges <chris.j.arges at ubuntu.com>
> ---
>   debian.quantal/control.d/flavour-control.stub |    5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/debian.quantal/control.d/flavour-control.stub b/debian.quantal/control.d/flavour-control.stub
> index 2b837de..e2d9a11 100644
> --- a/debian.quantal/control.d/flavour-control.stub
> +++ b/debian.quantal/control.d/flavour-control.stub
> @@ -26,10 +26,11 @@ Architecture: ARCH
>   Section: kernel
>   Priority: optional
>   Pre-Depends: dpkg (>= 1.10.24)
> +Provides: linux-image, linux-image-3.0, fuse-module, =PROVIDES=
>   Depends: ${misc:Depends}, ${shlibs:Depends}, initramfs-tools (>= 0.36ubuntu6), module-init-tools (>= 3.3-pre11-4ubuntu3), crda (>=1.1.1-1ubuntu2) | wireless-crda
>   Conflicts: hotplug (<< 0.0.20040105-1)
>   Recommends: BOOTLOADER
> -Suggests: fdutils, SRCPKGNAME-doc-PKGVER | SRCPKGNAME-source-PKGVER, SRCPKGNAME-tools
> +Suggests: fdutils, SRCPKGNAME-doc-PKGVER | SRCPKGNAME-source-PKGVER, SRCPKGNAME-tools, linux-headers-PKGVER-ABINUM-FLAVOUR
>   Description: Linux kernel image for version PKGVER on DESC
>    This package contains the Linux kernel image for version PKGVER on
>    DESC.
> @@ -72,6 +73,7 @@ Architecture: ARCH
>   Section: devel
>   Priority: optional
>   Depends: ${misc:Depends}, linux-headers-PKGVER-ABINUM, ${shlibs:Depends}
> +Provides: linux-headers, linux-headers-3.0
>   Description: Linux kernel headers for version PKGVER on DESC
>    This package provides kernel header files for version PKGVER on
>    DESC.
> @@ -84,6 +86,7 @@ Architecture: ARCH
>   Section: devel
>   Priority: optional
>   Depends: ${misc:Depends}
> +Provides: linux-debug
>   Description: Linux kernel debug image for version PKGVER on DESC
>    This package provides a kernel debug image for version PKGVER on
>    DESC.
>

I think the Provides part of this patch are not correct in that the 
kernel package does _not_ provide linux-image, etc. Those are real meta 
packages, so I don't think this does what you expect. Its likely benign, 
but incorrect nonetheless. I do realize that all of the other LTS 
kernels (as well as the Precise kernel) all have these Provides statements..

In fact, we've been discussing getting rid of those meta packages 
anyways 'cause they are not actually used.

rtg
-- 
Tim Gardner tim.gardner at canonical.com