[ 3.5.y.z extended stable ] Patch "ARM: S3C24XX: Correct NR_IRQS definition for s3c2440" has been added to staging queue

[Heiko Stübner]

Am Freitag, 26. April 2013, 12:06:29 schrieb Sylwester Nawrocki:
> On 04/24/2013 11:36 AM, Luis Henriques wrote:
> > This is a note to let you know that I have just added a patch titled
> > 
> >     ARM: S3C24XX: Correct NR_IRQS definition for s3c2440
> > 
> > to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree
> > 
> > which can be found at:
> >  http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/
> >  linux-3.5.y-queue
> > 
> > If you, or anyone else, feels it should not be added to this tree, please
> > reply to this email.
> 
> I think this patch is not even needed in 3.9, only 3.10-rc1+.
> 
> Heiko, can you confirm ?

Correct, including the patch in 3.5 should not be necessary, as the interrupt 
handling was still untouched then.


> I've tested 3.9-rc1 on s3c2440 SoC based board and all interrupts are
> registered properly without this patch.

Very strange ...

While the real rework of the s3c244x into the new irq structure will only 
enter mainline during the next merge window, the irq code in 3.9 already uses 
full irq domains. 

s3c24xx_init_irq which is still called at this state from the s3c244x boards, 
is creating the base irq-domains with default values (and the full 29 irqs in 
the subint domain) and as before the s3c244x irq initcall does then replace 
the demuxed interrupts

So in theory 3.9 should not work with the previous NR_IRQS value (and 
rightfully got you fix applied [2] ... or I'm overlooking something ;-)


> I believe this patch is needed only for trees containing patch series
> from Heiko [1], starting with commit:
> 
> 6f8d7ea275eb2a27fd62211e93921a82f367f939
> ARM: S3C24XX: move s3c244x irq init to common irq code
> 
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/arm/arm-soc.git/log/arch/arm/m
> ach-s3c24xx?h=for-next


Heiko

[2] 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/mach-
s3c24xx?id=b530f742ac27460d41d35b638ad6aad92044a982