Ack: [PATCH SRU Quantal/Raring] UBUNTU: SAUCE: alx: Don't check netif_running() before powering up

Brad Figg brad.figg at canonical.com
Wed Apr 24 19:56:11 UTC 2013


On 04/24/2013 12:35 PM, Tim Gardner wrote:
> (sent upstream to unified-drivers at lists.infradead.org)
> 
> The resume function must power up the device regardless of the state
> of the network stack.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
> 
> Tested on an AMD system with HW that exhibits the problem.
> 
>  ubuntu/alx/alx_main.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ubuntu/alx/alx_main.c b/ubuntu/alx/alx_main.c
> index 700ebf1..03bda8b 100644
> --- a/ubuntu/alx/alx_main.c
> +++ b/ubuntu/alx/alx_main.c
> @@ -1694,9 +1694,6 @@ static int alx_resume(struct device *dev)
>  	struct alx_hw *hw = &adpt->hw;
>  	int err;
>  
> -	if (!netif_running(netdev))
> -		return 0;
> -
>  	pci_set_power_state(pdev, PCI_D0);
>  	pci_restore_state(pdev);
>  	pci_save_state(pdev);
> 


-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list