[APPLIED] Re: [PATCH] Revert "drm/i915: GFX_MODE Flush TLB Invalidate Mode must be '1' for scanline waits"

Tim Gardner tim.gardner at canonical.com
Tue Apr 23 19:31:38 UTC 2013


On 04/23/2013 12:46 PM, Steve Conklin wrote:
> On 04/22/2013 04:23 PM, Steve Conklin wrote:
>> This reverts commit 30ae292ec68402c773ddc8c80f83f7cd84289a39.
>>
>> This has been shown to cause GPU hangs
>> ---
>>   drivers/gpu/drm/i915/intel_ringbuffer.c |    5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index c3654ff..fbaa785 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -422,11 +422,6 @@ static int init_render_ring(struct intel_ring_buffer *ring)
>>   	if (INTEL_INFO(dev)->gen >= 6)
>>   		I915_WRITE(MI_MODE, GFX_MODE_ENABLE(ASYNC_FLIP_PERF_DISABLE));
>>
>> -	/* Required for the hardware to program scanline values for waiting */
>> -	if (INTEL_INFO(dev)->gen == 6)
>> -		I915_WRITE(GFX_MODE,
>> -			   GFX_MODE_ENABLE(GFX_TLB_INVALIDATE_ALWAYS));
>> -
>>   	if (IS_GEN7(dev))
>>   		I915_WRITE(GFX_MODE_GEN7,
>>   			   GFX_MODE_DISABLE(GFX_TLB_INVALIDATE_ALWAYS) |
>>
>
>

There is no BugLink in the Precise patch as applied to master-next.

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list