APPLIED: [PATCH] UBUNTU: SAUCE: Fix oops in patch_hdmi due to missing hda_gen_spec struct

Tim Gardner tim.gardner at canonical.com
Thu Apr 18 15:50:24 UTC 2013


On 04/18/2013 02:46 AM, David Henningsson wrote:
> A recent commit added calls to the snd_hda_*_fixup functions. Under
> kernel 3.8 and earlier these functions require a hda_gen_spec struct
> to be first in the spec struct, or memory corruption might occur.
> 
> Buglink: https://bugs.launchpad.net/bugs/1169984
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  sound/pci/hda/patch_hdmi.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 6ae6331..1eee344 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -80,6 +80,7 @@ struct hdmi_spec_per_pin {
>  };
>  
>  struct hdmi_spec {
> +	struct hda_gen_spec gen;
>  	int num_cvts;
>  	struct hdmi_spec_per_cvt cvts[MAX_HDMI_CVTS];
>  
> 

Dangerous 'void *' games. For which stable kernels is this required ?
c9ce6b260b039392b24ad65954788047d13d4c9a appears to be the upstream fix
but it is quite intrusive.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list