[Quantal][PATCH 1/1] Revert "ALSA: hda/realtek - Call alc_auto_parse_customize_define() always after fixup"

[Herton Ronaldo Krzesinski]

On Wed, Sep 26, 2012 at 12:17:36PM -0400, joseph.salisbury at canonical.com wrote:
> From: Joseph Salisbury <joseph.salisbury at canonical.com>
> 
> This reverts commit af741c150f66db8d1da6f82ac75e2571f7f1dd38.
> 
> BugLink:  http://bugs.launchpad.net/bugs/1006690
> Backport required to apply this commit to Quantal.
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 

The real problem with commit af741c150f66db8d1da6f82ac75e2571f7f1dd38 is
that alc269 for example has this check:

        if (codec->vendor_id == 0x10ec0269) {
                spec->codec_variant = ALC269_TYPE_ALC269VA;
                switch (alc_get_coef0(codec) & 0x00f0) {
                case 0x0010:
                        if (codec->bus->pci->subsystem_vendor == 0x1025 &&
                            spec->cdefine.platform_type == 1)
                                err = alc_codec_rename(codec, "ALC271X");
                        spec->codec_variant = ALC269_TYPE_ALC269VB;
                        break;

When alc_auto_parse_customize_define was moved after this,
spec->cdefine.platform_type will always be zero, since it's filled by
alc_auto_parse_customize_define. So it prevents alc271_fixup_dmic to
being run, and from that I expect the mic recording failure.

A similar issue happens with alc662. But the patch was not at all wrong,
we need to run alc_auto_parse_customize_define after
alc_apply_fixup(codec, ALC_FIXUP_ACT_PRE_PROBE) so we can properly take
ALC_FIXUP_SKU_IGNORE quirks into account. So I'm not acking the revert.

Chicken and egg problem... I'll try to cook up a patch to fix the
problem.

-- 
[]'s
Herton