[PATCH 13/19] UBUNTU: SAUCE: net: calxedaxgmac: drop some unnecessary register writes

Ike Panhc ike.pan at canonical.com
Mon Oct 1 10:03:00 UTC 2012


From: Rob Herring <rob.herring at calxeda.com>

BugLink: http://launchpad.net/bugs/1059432

The interrupts have already been cleared, so we don't need to clear them
again. Also, we could miss interrupts if they are cleared, but we don't
process the packet.

Signed-off-by: Rob Herring <rob.herring at calxeda.com>
Signed-off-by: Ike Panhc <ike.pan at canonical.com>
---
 drivers/net/ethernet/calxeda/xgmac.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 1cd13bf..3b87d0e 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -851,8 +851,6 @@ static void xgmac_tx_complete(struct xgmac_priv *priv)
 	int i;
 	void __iomem *ioaddr = priv->base;
 
-	writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
-
 	while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
 		unsigned int entry = priv->tx_tail;
 		struct sk_buff *skb = priv->tx_skbuff[entry];
@@ -1154,9 +1152,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)
 		struct sk_buff *skb;
 		int frame_len;
 
-		writel(DMA_STATUS_RI | DMA_STATUS_NIS,
-		       priv->base + XGMAC_DMA_STATUS);
-
 		entry = priv->rx_tail;
 		p = priv->dma_rx + entry;
 		if (desc_get_owner(p))
-- 
1.7.9.5





More information about the kernel-team mailing list