[Precise SRU] thinkpad-acpi: fix issuing duplicated key events for brightness up/down

Alex Hung alex.hung at canonical.com
Thu Nov 29 07:02:30 UTC 2012


SRU Justification:

Impact:
  Single brightness up/down hotkey press sends duplicated keycode.

Fix:
  The tp_features.bright_acpimode will not be set correctly for brightness
  control because ACPI_VIDEO_HID will not be located in ACPI. As a result,
  a duplicated key event will always be sent. acpi_video_backlight_support()
  is sufficient to detect standard ACPI brightness control.

Test:
  I tested on Thinkpad x200, and it removed the additional keycode.

Note:
  The patch is included in upstream, but it is needed to be included
  in precise kernel.

BugLink: http://bugs.launchpad.net/bugs/841315

Alex Hung (1):
  thinkpad-acpi: fix issuing duplicated key events for brightness
    up/down

 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.9.5





More information about the kernel-team mailing list