[PATCH 245/270] USB: mct_u232: fix broken close

Ben Hutchings ben at decadent.org.uk
Tue Nov 27 16:15:51 UTC 2012


On Mon, 2012-11-26 at 14:58 -0200, Herton Ronaldo Krzesinski wrote:
> 3.5.7u1 -stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Johan Hovold <jhovold at gmail.com>
> 
> commit 5260e458f5eff269a43e4f1e9c47186c57b88ddb upstream.
> 
> Make sure generic close is called at close.
> 
> The driver relies on the generic write implementation but did not call
> generic close.
> 
> Note that the call to kill the read urb is not redundant, as mct_u232
> uses an interrupt urb from the second port as the read urb and that
> generic close therefore fails to kill it.
> 
> Compile-only tested.
> 
> Signed-off-by: Johan Hovold <jhovold at gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
[...]

This is missing on 3.4; the version I used for 3.2 (attached) should be
applicable.

Ben.

-- 
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: usb-mct_u232-fix-broken-close.patch
Type: text/x-patch
Size: 1478 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20121127/c82700d8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20121127/c82700d8/attachment.sig>


More information about the kernel-team mailing list