[ 3.5.yuz extended stable ] Patch "ALSA: hda - Add missing hda_gen_spec to struct via_spec" has been added to staging queue

Herton Ronaldo Krzesinski herton.krzesinski at canonical.com
Thu Nov 15 05:49:50 UTC 2012

This is a note to let you know that I have just added a patch titled

    ALSA: hda - Add missing hda_gen_spec to struct via_spec

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



>From 7c798a1c758e91d8da75464b1d107c633f0cdb65 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai at suse.de>
Date: Wed, 10 Oct 2012 08:41:42 +0200
Subject: [PATCH] ALSA: hda - Add missing hda_gen_spec to struct via_spec

commit 7819d1c70eb6a57e43554d86e10b39d1e106ed65 upstream.

The commit [4b527b65 ALSA: hda - limit internal mic boost for Asus
X202E] introduced the use of auto-parser code, but it forgot to add
struct hda_gen_spec at the head of codec->spec which the auto-parser
assumes silently.  Without this record, it may result in memory

This patch adds the missing piece.

Signed-off-by: Takashi Iwai <tiwai at suse.de>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
 sound/pci/hda/patch_via.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 9c35043..92dff3e 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -118,6 +118,8 @@ enum {

 struct via_spec {
+	struct hda_gen_spec gen;
 	/* codec parameterization */
 	const struct snd_kcontrol_new *mixers[6];
 	unsigned int num_mixers;
@@ -246,6 +248,7 @@ static struct via_spec * via_new_spec(struct hda_codec *codec)
 	/* VT1708BCE & VT1708S are almost same */
 	if (spec->codec_type == VT1708BCE)
 		spec->codec_type = VT1708S;
+	snd_hda_gen_init(&spec->gen);
 	return spec;

@@ -1628,6 +1631,7 @@ static void via_free(struct hda_codec *codec)
+	snd_hda_gen_free(&spec->gen);


More information about the kernel-team mailing list