[ 3.5.yuz extended stable ] Patch "qla2xxx: Fix endianness of task management response code" has been added to staging queue

Herton Ronaldo Krzesinski herton.krzesinski at canonical.com
Thu Nov 15 05:47:59 UTC 2012

This is a note to let you know that I have just added a patch titled

    qla2xxx: Fix endianness of task management response code

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



>From b7a210a2e6218da3e5ded34750174455ddd2c1f9 Mon Sep 17 00:00:00 2001
From: Roland Dreier <roland at purestorage.com>
Date: Tue, 18 Sep 2012 15:10:56 -0700
Subject: [PATCH] qla2xxx: Fix endianness of task management response code

commit e4b11b89f9039ca97b2ed1b6efeb6749fbdeb252 upstream.

The qla2xxx firmware actually expects the task management response
code in a CTIO IOCB with SCSI status mode 1 to be in little-endian
byte order, ie the response code should be the first byte in the
sense_data[] array.  The old code erroneously byte-swapped the
response code, which puts it in the wrong place on the wire and leads
to initiators thinking every task management request succeeds (since
they see 0 in the byte where they look for the response code).

Signed-off-by: Roland Dreier <roland at purestorage.com>
Cc: Chad Dupuis <chad.dupuis at qlogic.com>
Cc: Arun Easi <arun.easi at qlogic.com>
Acked-by: Saurav Kashyap <saurav.kashyap at qlogic.com>
Signed-off-by: Nicholas Bellinger <nab at linux-iscsi.org>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
 drivers/scsi/qla2xxx/qla_target.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 77759c7..5a71e84 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1403,7 +1403,7 @@ static void qlt_24xx_send_task_mgmt_ctio(struct scsi_qla_host *ha,
 	ctio->u.status1.scsi_status =
 	ctio->u.status1.response_len = __constant_cpu_to_le16(8);
-	((uint32_t *)ctio->u.status1.sense_data)[0] = cpu_to_be32(resp_code);
+	ctio->u.status1.sense_data[0] = resp_code;

 	qla2x00_start_iocbs(ha, ha->req);

More information about the kernel-team mailing list