[Precise] SRU: Build hpwdt module in 12.04 kernel

[Stefan Bader]

On 13.11.2012 12:13, Bouchard Louis wrote:
> Le 12/11/2012 16:12, Bouchard Louis a écrit :
>> BugLink: http://launchpad.net/bugs/1076342
> Hello,
> 
>>
> 
>> == SRU Justification ==
>>
>> == Impact==
>>
>> This will allow usage of the hpwdt module on the 12.04 LTS version
>>
>> == Fix ==
>>
>> Mostly add CONFIG_HPWDT_NMI_DECODING=y and CONFIG_HP_WATCHDOG=m as a
>> kernel build option
>>
>> == Testcase ==
>>
>> modprobe hpwdt on new kernel should complete normally.
>>
>> == Regression ==
>>
>> None expected as it is limited to HP iLO hardware and already being
>> build for Quantal
>>
>> Kind Regards,
>>
>> ...Louis
>>
> 
> This would have been more complete with an actual patch outlining the
> changes. Here it is.
> 
> Kind regards,
> 
> ...Louis
> 
> 
> 
I don't see any reasons not to do it, the only comment/suggestion I have is
whether it the watchdog option should be different for x86 flavours at least.
Sometimes it is even ok to have it in the common part and on arm it would go
away automatically due to unfulfilled dependencies.
Anyway at least all x86 flavours should be =m if that does not break any build.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20121113/26ff22b0/attachment.sig>