[Oneiric PATCH] UBUNTU: SAUCE: remove __initdata from vesafb_fix

Herton Ronaldo Krzesinski herton.krzesinski at canonical.com
Fri Mar 30 19:39:07 UTC 2012


On Fri, Mar 30, 2012 at 09:49:59AM -0600, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/969309
> 
> OK. Then, I think we also want to fix these warnings probably introduced by
> commit a6021559 "UBUNTU: SAUCE: (no-up) Modularize vesafb".
> 
> WARNING: drivers/video/vesafb.o(.exit.text+0x42): Section mismatch in reference from the function vesafb_remove() to the (unknown reference) .init.data:(unknown)
> The function __exit vesafb_remove() references
> a (unknown reference) __initdata (unknown).
> This is often seen when error handling in the exit function
> uses functionality in the init path.
> The fix is often to remove the __initdata annotation of
> (unknown) so it may be used outside an init section.
> 
> WARNING: drivers/video/vesafb.o(.exit.text+0x4a): Section mismatch in reference from the function vesafb_remove() to the variable .init.data:vesafb_fix
> The function __exit vesafb_remove() references
> a variable __initdata vesafb_fix.
> This is often seen when error handling in the exit function
> uses functionality in the init path.
> The fix is often to remove the __initdata annotation of
> vesafb_fix so it may be used outside an init section.
> 
> Reported-by: Tetsuo Honda <from-ubuntu at I-love.SAKURA.ne.jp>
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>

Ack for all the 3 patches (oneiric, natty, lucid), but shouldn't this
also be marked as (no-up) in the commit title?

> ---
>  drivers/video/vesafb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
> index 9d6995d..eb78a59 100644
> --- a/drivers/video/vesafb.c
> +++ b/drivers/video/vesafb.c
> @@ -46,7 +46,7 @@ static struct fb_var_screeninfo vesafb_defined __initdata = {
>  	.vmode		= FB_VMODE_NONINTERLACED,
>  };
>  
> -static struct fb_fix_screeninfo vesafb_fix __initdata = {
> +static struct fb_fix_screeninfo vesafb_fix = {
>  	.id	= "VESA VGA",
>  	.type	= FB_TYPE_PACKED_PIXELS,
>  	.accel	= FB_ACCEL_NONE,
> -- 
> 1.7.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 

-- 
[]'s
Herton




More information about the kernel-team mailing list