[Lucid PATCH 07/10] usermodehelper: ____call_usermodehelper() doesn't need do_exit()

Tim Gardner tim.gardner at canonical.com
Mon Mar 26 18:01:40 UTC 2012

From: Oleg Nesterov <oleg at redhat.com>

BugLink: http://bugs.launchpad.net/bugs/963685

Minor cleanup.  ____call_usermodehelper() can simply return, no need to
call do_exit() explicitely.

Signed-off-by: Oleg Nesterov <oleg at redhat.com>
Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp>
Cc: Rusty Russell <rusty at rustcorp.com.au>
Cc: Tejun Heo <tj at kernel.org>
Cc: David Rientjes <rientjes at google.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
(cherry picked from commit 5b9bd473e3b8a8c6c4ae99be475e6e9b27568555)

Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
 kernel/kmod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/kmod.c b/kernel/kmod.c
index ca3fda9..1244808 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -189,7 +189,7 @@ static int ____call_usermodehelper(void *data)
 	/* Exec failed? */
 	sub_info->retval = retval;
-	do_exit(0);
+	return 0;
 void call_usermodehelper_freeinfo(struct subprocess_info *info)

More information about the kernel-team mailing list