[PATCH 146/241] jbd: Fix lock ordering bug in journal_unmap_buffer()
Herton Ronaldo Krzesinski
herton.krzesinski at canonical.com
Thu Dec 13 13:58:31 UTC 2012
220.127.116.11 -stable review patch. If anyone has any objections, please let me know.
From: Jan Kara <jack at suse.cz>
commit 25389bb207987b5774182f763b9fb65ff08761c8 upstream.
Commit 09e05d48 introduced a wait for transaction commit into
journal_unmap_buffer() in the case we are truncating a buffer undergoing commit
in the page stradding i_size on a filesystem with blocksize < pagesize. Sadly
we forgot to drop buffer lock before waiting for transaction commit and thus
deadlock is possible when kjournald wants to lock the buffer.
Fix the problem by dropping the buffer lock before waiting for transaction
commit. Since we are still holding page lock (and that is OK), buffer cannot
disappear under us.
Signed-off-by: Jan Kara <jack at suse.cz>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski at canonical.com>
fs/jbd/transaction.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 78b7f84..7f5120b 100644
@@ -1961,7 +1961,9 @@ retry:
More information about the kernel-team