[Quantal][PATCH 11/29] be2net: Fix error while toggling autoneg of pause parameters

Jesse Sung jesse.sung at canonical.com
Thu Dec 13 06:49:44 UTC 2012


From: Padmanabh Ratnakar <padmanabh.ratnakar at emulex.com>

BugLink: https://launchpad.net/bugs/1083088

Autonegotiation of pause parameters is possible only on some PHYs.
Ability of autoneg of pause parameters is reported by adapter.
Autoneg of pause parameters cannot be changed from driver.
Fix driver to give error when autoneg mode is toggled by user.

Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar at emulex.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit c871c5f29315aaf27acf6ceed7a69f9069049639)

Signed-off-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>
---
 drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 59ee51a..c0e7006 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -648,7 +648,7 @@ be_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 	struct be_adapter *adapter = netdev_priv(netdev);
 	int status;
 
-	if (ecmd->autoneg != 0)
+	if (ecmd->autoneg != adapter->phy.fc_autoneg)
 		return -EINVAL;
 	adapter->tx_fc = ecmd->tx_pause;
 	adapter->rx_fc = ecmd->rx_pause;
-- 
1.7.10.4





More information about the kernel-team mailing list