ACK/wnp: [raring][PATCH] UBUNTU: SAUCE: add eeprom_bad_csum_allow module parameter

Stefan Bader stefan.bader at canonical.com
Wed Dec 12 14:39:18 UTC 2012


And if I have enough coffee I might even realize I pressed "reply" and not
"reply list"...

And Chris, nitpick in that case means "Stefan having his moments"... This could
result in sarcasm which I was told isn't expected from Germans. :-P

-Stefan

-------- Original Message --------
Subject: ACK/wnp: [raring][PATCH] UBUNTU: SAUCE: add eeprom_bad_csum_allow
module parameter
Date: Wed, 12 Dec 2012 09:14:51 +0100
From: Stefan Bader <stefan.bader at canonical.com>
To: Chris J Arges <chris.j.arges at canonical.com>

On 11.12.2012 22:45, Chris J Arges wrote:
> BugLink: http://bugs.ubuntu.com/bugs/1070182
> 
> This patch adds the eeprom_bad_csum_allow module parameter for the
> e1000 and e1000e drivers. This allows users of affected hardware
> to bypass EEPROM/NVM checksum validation.
> Based on a patch by Ben Collins <bcollins at ubuntu.com>
> 
> This parameter was already present in the e100 driver already, this
> SAUCE patch just adds this functionality for the e1000 and e1000e
> drivers. This fixes cases where NVM checksum validation fails, yet the
> hardware still functions correctly if we skip this. This patch has
> already been verified in the bug.
> 

Change is limited to specific cases and must be opted in by the user. So
regression potential is low.

Minor nitpick, it might be me and my non-native English but:

"/* if we allow bad checksums, just break */"

does not sound that optimistic... ;)

Acked-by: Stefan Bader <stefan.bader at canonical.com>







-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20121212/9ff9a1b4/attachment.sig>


More information about the kernel-team mailing list