[Precise][PATCH 1/1] UBUNTU: SAUCE: SECCOMP: audit: fix build on archs without CONFIG_AUDITSYSCALL

Kees Cook kees at ubuntu.com
Tue Dec 4 18:56:39 UTC 2012


Ah, good catch. For backports, this seems fine. Going forward, I would
expect we'd want CONFIG_AUDITSYSCALL enabled for ARM.

-Kees

On Tue, Dec 04, 2012 at 02:33:20PM +0000, Luis Henriques wrote:
> BugLink: http://bugs.launchpad.net/bugs/1079469
> 
> Build is broken for armel or armhf because they don't define
> __audit_seccomp(), required by:
> 
> 3479c36 seccomp: forcing auditing of kill condition
> 
> This fixes the builds defining an empty macro for this function.
> 
> Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
> Cc: Kees Cook <kees at ubuntu.com>
> ---
>  include/linux/audit.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/audit.h b/include/linux/audit.h
> index ab40f49..225b4e4 100644
> --- a/include/linux/audit.h
> +++ b/include/linux/audit.h
> @@ -566,6 +566,7 @@ extern int audit_signals;
>  #define audit_inode_child(i,p) do { ; } while (0)
>  #define audit_core_dumps(i) do { ; } while (0)
>  #define audit_seccomp(i,s,c) do { ; } while (0)
> +#define __audit_seccomp(i,s,c) do { ; } while (0)
>  #define auditsc_get_stamp(c,t,s) (0)
>  #define audit_get_loginuid(t) (-1)
>  #define audit_get_sessionid(t) (-1)
> -- 
> 1.7.10.4
-- 
Kees Cook




More information about the kernel-team mailing list