Herton Ronaldo Krzesinski
herton.krzesinski at canonical.com
Fri Aug 24 00:46:42 UTC 2012
On Thu, Aug 23, 2012 at 02:14:23PM -0600, Tim Gardner wrote:
> I've repushed with an update to "net: Allow driver to limit number of
> GSO segments per skb"
This one still doesn't look ok. You clear dev->features, but the
behaviour of the upstream patch is different: they copy dev->features to
a local variable, and clear that, passing to netif_needs_gso, otherwise
after you clear first time, dev->features will have always the flags
cleared, and the checks are per skb, shouldn't be cleared globally in
dev->features. Fixing this, Ack from me for the patch series, the other
things I just wanted to point out but should be benign or style issues.
> Tim Gardner tim.gardner at canonical.com
More information about the kernel-team