[Quantal][PULL] Cypress PS/2 Trackpad driver
seth.forshee at canonical.com
Tue Aug 14 18:27:22 UTC 2012
On Tue, Aug 14, 2012 at 10:38:02AM -0700, Kamal Mostafa wrote:
> > One possible problem for us is that the way you've taken their original
> > patch and then applied fixes on top of it, we could end up with commits
> > that won't build under certain configurations (i.e.
> > CONFIG_MOUSE_PS2_CYPRESS=n up to "UBUNTU: SAUCE: input: Cypress PS/2
> > Trackpad fix no-config stubs"). We'd probably always have it enabled of
> > course, but I thought it was worth mentioning.
> Ah, but I don't think that's so. I think it will build okay at every
> commit in any configuration, because I don't actually add cypress_ps2.o
> to the Makefile until "UBUNTU: SAUCE: input: Cypress PS/2 Trackpad link
> driver into psmouse-base". Before that point, cypress_ps2.[ch] won't
> even try to be compiled so there's no problem there, and its nice that
> we can keep commits of their original code as they delivered it. Yes?
Okay, I missed that. I don't expect any build failures in that case.
More information about the kernel-team