[Acked w/ comments] [Precise SRU PATCH] HID: multitouch: add new PID from Ideacom

Andy Whitcroft apw at canonical.com
Thu Aug 9 09:31:45 UTC 2012


On Thu, Aug 09, 2012 at 10:45:24AM +0800, Ming Lei wrote:
> From: Benjamin Tissoires <benjamin.tissoires at enac.fr>
> 
> SRU Justification:
> 
> Impact:
>         - without the patch, touchpad(1cb6:6651) can't be used on Precise
> Fix:
>         - After applying the patch, touchpad(1cb6:6651) can be used on Precise
> 
> BugLink: http://bugs.launchpad.net/bugs/1026174

This appears to be a direct cherry-pick from the commit below, you
should cherry-pick -x the commit to get the upstream commit id in the
patch.

commit 71078b0deba8420e00b0c5e39ea359dbcaa11114
Author: Benjamin Tissoires <benjamin.tissoires at enac.fr>
Date:   Tue Mar 6 10:53:46 2012 +0100

    HID: multitouch: add new PID from Ideacom

The SRU justification also should go into the BUG for the SRU
team.

With the upstream commit id added:

Acked-by: Andy Whitcroft <apw at canonical.com>

> Signed-off-by: Benjamin Tissoires <benjamin.tissoires at enac.fr>
> Acked-by: Henrik Rydberg <rydberg at euromail.se>
> Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> Signed-off-by: Ming Lei <ming.lei at canonical.com>
> ---
>  drivers/hid/hid-ids.h        |    1 +
>  drivers/hid/hid-multitouch.c |    3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5cb1d63..10a9ca9 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -375,6 +375,7 @@
>  
>  #define USB_VENDOR_ID_IDEACOM		0x1cb6
>  #define USB_DEVICE_ID_IDEACOM_IDC6650	0x6650
> +#define USB_DEVICE_ID_IDEACOM_IDC6651	0x6651
>  
>  #define USB_VENDOR_ID_ILITEK		0x222a
>  #define USB_DEVICE_ID_ILITEK_MULTITOUCH	0x0001
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 03990a8..c7ee035 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -828,6 +828,9 @@ static const struct hid_device_id mt_devices[] = {
>  	{ .driver_data = MT_CLS_SERIAL,
>  		HID_USB_DEVICE(USB_VENDOR_ID_IDEACOM,
>  			USB_DEVICE_ID_IDEACOM_IDC6650) },
> +	{ .driver_data = MT_CLS_SERIAL,
> +		HID_USB_DEVICE(USB_VENDOR_ID_IDEACOM,
> +			USB_DEVICE_ID_IDEACOM_IDC6651) },
>  
>  	/* Ilitek dual touch panel */
>  	{  .driver_data = MT_CLS_DEFAULT,
> -- 

-apw




More information about the kernel-team mailing list