[Precise PATCH 0/6] Support for new Sentelic touchpad (LP #969334)

Eric Miao eric.miao at canonical.com
Fri Apr 13 12:25:13 UTC 2012


GIT PULL sent out, addressed comments from Leann and Brad, please help
check.

On Fri, Apr 13, 2012 at 1:02 AM, Brad Figg <brad.figg at canonical.com> wrote:
>
> These patch submission details area all spelled out in:
>  https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat
>
> Brad
>
> On 04/12/2012 09:58 AM, Leann Ogasawara wrote:
>> On Thu, 2012-04-12 at 21:58 +0800, Eric Miao wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/969334
>>>
>>> These patches have actually been upstreamed and landed in v3.4-rc1:
>>>
>>>   Sentelic's originally posted patches: https://lkml.org/lkml/2012/3/23/1
>>>
>>>   Merged into Linus tree: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=2f7fa1be66dce77608330c5eb918d6360b5525f2
>>>
>>> The 6 patches below are applicable to the current precise kernel, and
>>> have been verified to work by at least Ike and the bug reporter.
>>>
>>> I know this is really late in the dev phase, but this is a hwcert block
>>> issue, and I'm posting here in the hope that we can find some solution
>>> out.  There are several options from my understanding:
>>>
>>>   1) get the patches to be accepted by -stable
>>>
>>>   2) a dkms package
>>>
>>>   3) get a minimal patch to enable this so to reduce the possibility
>>>      of regression to minimal
>>>
>>>   4) merge this series as is
>>
>> Patches 1/6 and 2/6 look to be a fairly low risk of regression.  The
>> remaining patches (including the additional patch Chase mentioned) look
>> to only affect the sentelic driver and thus limit the scope for
>> regression potential.  Given that there has been positive test
>> confirmation and these patches have been included upstream, I'd be
>> willing to give these an Ack for Precise and have them bake through the
>> SRU process.
>>
>> However, I would first ask for a few modifications to the commit
>> messages...
>>
>> 1) Please update the commits to mention which upstream commit they
>> originate from.  Assuming they were clean cherry-picks into Precise, I'd
>> like to see the following in the commit message (it's auto inserted if
>> you use the cherry-pick -x option):
>>
>> (cherry picked from commit <sha1>)
>>
>> otherwise if they needed fixing up before being applied to Precise,
>> please use:
>>
>> (backported from commit <sha1>)
>>
>> 2) If you could add the BugLink to each of the individual commits, that
>> would be appreciated too.
>>
>> 3) Lastly, if you want to make the above changes and just send a single
>> pull request rather than resending the patches individually, that would
>> be fine.
>>
>> Pending the above,
>> Acked-by: Leann Ogasawara <leann.ogasawara at canonical.com>
>>
>>> While 1) is not likely, and 2) is definitely what we want. Are there
>>> any other options?
>>>
>>> --------------------------------------------------------------------
>>>
>>> Andres Salomon (1):
>>>   Input: psmouse - allow drivers to use psmouse_{de,}activate
>>>
>>> Oskari Saarenmaa (1):
>>>   Input: sentelic - improve packet debugging information
>>>
>>> Paul Fox (1):
>>>   Input: psmouse - use psmouse_[de]activate() from sentelic and hgpk
>>>     drivers
>>>
>>> Tai-hwa Liang (3):
>>>   Input: sentelic - refactor code for upcoming new hardware support
>>>   Input: sentelic - enabling absolute coordinates output for newer
>>>     hardware
>>>   Input: sentelic - minor code cleanup
>>>
>>>  drivers/input/mouse/hgpk.c         |    9 +-
>>>  drivers/input/mouse/psmouse-base.c |   15 ++-
>>>  drivers/input/mouse/psmouse.h      |    2 +
>>>  drivers/input/mouse/sentelic.c     |  306 +++++++++++++++++++++++++++---------
>>>  drivers/input/mouse/sentelic.h     |   35 ++++-
>>>  5 files changed, 275 insertions(+), 92 deletions(-)
>>>
>>> --
>>> 1.7.9.1
>>>
>>>
>>
>>
>>
>
>
> --
> Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list