Ack: [Precise][PATCH] UBUNTU: [Config] Fix invalid linux-headers link

Tim Gardner tim.gardner at canonical.com
Tue Apr 10 11:48:16 UTC 2012


On 04/10/2012 03:35 AM, Andy Whitcroft wrote:
> On Thu, Apr 05, 2012 at 11:29:21AM -0700, Leann Ogasawara wrote:
>>> @@ -191,7 +191,7 @@ endif
>>>  	$(SHELL) $(DROOT)/scripts/link-headers "$(hdrdir)" "$(basepkg)" "$*"
>>>  	# Setup the proper asm symlink
>>>  	rm -f $(hdrdir)/include/asm
>>> -	ln -s asm-$(asm_link) $(hdrdir)/include/asm
>>> +	(cd $(hdrdir)/include; ln -s asm-generic asm)
> 
> I do not understand why we would link asm to asm-generic.  asm-generic
> is for use by architectures which chose to not override a specific file.
> I don't think this link makes sense?
> 

So you think we should drop the link altogether ?

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list