Oneiric SRU: UBUNTU: SAUCE: OMAP3 and 4 hwmod I2C units only allow 16 bit access
seth.forshee at canonical.com
Mon Sep 19 14:28:22 UTC 2011
On Mon, Sep 19, 2011 at 07:53:42AM -0600, Tim Gardner wrote:
> From f8f23179a8c9d046d30f2cfec094e879bd8543b3 Mon Sep 17 00:00:00 2001
> From: Andy Green <andy.green at linaro.org>
> Date: Mon, 19 Sep 2011 07:49:10 -0600
> Subject: [PATCH] UBUNTU: SAUCE: OMAP3 and 4 hwmod I2C units only allow 16 bit access
> BugLink: http://bugs.launchpad.net/bugs/852225
> Peter Maydell noticed when running under QEMU he was getting
> errors reporting 32-bit access to I2C peripheral unit registers
> that are documented to be 8 or 16-bit only
> The I2C driver is blameless as it wraps its accesses in a
> function using __raw_writew and __raw_readw, it turned out it
> is the hwmod stuff.
> However the hwmod code already has a flag to force a
> perhipheral unit to only be accessed using 16-bit operations.
> This patch applies the 16-bit only flag to the OMAP3xxx and
> OMAP44xx hwmod structs.
>  OMAP4430 Technical reference manual section 184.108.40.206
>  OMAP3530 Techincal reference manual section 18.6
> Cc: patches at linaro.org
> Reported-by: Peter Maydell <peter.maydell at linaro.org>
> Signed-off-by: Andy Green <andy.green at linaro.org>
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
Looks reasonable, and seems to be true to the upstream patch.
Acked-by: Seth Forshee <seth.forshee at canonical.com>
More information about the kernel-team