[PATCH maverick, maverick/ti-omap4, lucid] core: Fix memory leak/corruption on VLAN GRO_DROP

Stefan Bader stefan.bader at canonical.com
Mon Sep 19 14:00:07 UTC 2011

From: Herbert Xu <herbert.xu at redhat.com>

The function napi_reuse_skb is only meant to be used for packets
merged by GRO.  Using it on the VLAN path will lead to memory
leaks/corruption.  This patch is based on Jay Vosburgh's patch,
and it fixes the problem by calling kfree_skb on the VLAN GRO_DROP
path instead of napi_reuse_skb.

Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
Signed-off-by: Jarod Wilson <jarod at redhat.com>

BugLink: http://bugs.launchpad.net/bugs/844361
(backported from kernel-2.6.18-238.19.1.el5.src.rpm)

Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
 net/core/dev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 85e3f8d..52ec7f4 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3266,6 +3266,9 @@ gro_result_t napi_frags_finish(struct napi_struct *napi, struct sk_buff *skb,
 	case GRO_DROP:
+		kfree_skb(skb);
+		break;
 		napi_reuse_skb(napi, skb);

More information about the kernel-team mailing list