ACK w. notes: [PATCH] UBUNTU: SAUCE: acer-wmi: Add wireless quirk for Lenovo 3000 N200

Stefan Bader stefan.bader at canonical.com
Fri Oct 7 08:20:29 UTC 2011


On 06.10.2011 22:35, Seth Forshee wrote:
> This patch has been submitted upstream and acked by the acer-wmi
> maintainer, but it has not yet been merged. Without this fix the
> affected model has a permanent soft block on wireless whenever acer-wmi
> is loaded, and the regression potential of the fix is very small as it
> is a DMI quirk for a single model. Therefore, I'm proposing we SRU this
> as a sauce patch at this time to get the fix into oneiric sooner.
> 
> == SRU Justification ==
> 
> Impact: acer-wmi is lacking a required quirk for the Lenovo 3000 N200
> wlan rfkill. As a result, wireless is permanently blocked on this
> machine whenever acer-wmi is loaded.
> 
> Fix: Add quirk to use the correct EC register for updating the wlan
> rfkill status.
> 
> Testcase: Loading acer-wmi without the fix results in a permanent wlan
> soft block. With the fix the rfkill switch behaves as expected. Verified
> against natty on LP #857297.
> 
> BugLink: http://bugs.launchpad.net/bugs/857297
> 

Patch looks isolated enough to only affect the target hw where it can be tested.
Looks to me like both patches are actually the same (just differing in relative
position). So imo it would be simpler to send it once with both releases targeted.
A bit torn between waiting for it to appear upstream at least and have it done now.





More information about the kernel-team mailing list