[PATCH] drm/i915: add multi-threaded forcewake support

Robert Hooker sarvatt at ubuntu.com
Tue Nov 22 16:27:13 UTC 2011


On Tue, Nov 22, 2011 at 7:02 AM, Herton Ronaldo Krzesinski
<herton.krzesinski at canonical.com> wrote:
> It seems the following is missing from this backport, looking at the
> posted patch on
> http://permalink.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/7192
>
> #define NEEDS_FORCE_WAKE(dev_priv, reg) \
>        (((dev_priv)->info->gen >= 6) && \
> -       ((reg) < 0x40000) && \
> -       ((reg) != FORCEWAKE))
> +        ((reg) < 0x40000) &&            \
> +        ((reg) != FORCEWAKE) &&         \
> +        ((reg) != ECOBUS))
>
> Any reason to not update the NEEDS_FORCE_WAKE macro?
>
>
> --
> []'s
> Herton
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

My mistake, thanks for catching that! I only meant to drop the
identical hunk from i915_drv.c which isn't there in 3.0 due to
f700088333c5c7e5a7f4ab71b642362290259e26 but ended up dropping it from
i915_drv.h too.




More information about the kernel-team mailing list