[Precise][PATCH] (pre-stable) HID: bump maximum global item tag report size to 96 bytes

Tim Gardner tim.gardner at canonical.com
Thu Nov 17 11:58:46 UTC 2011


On 11/16/2011 01:37 PM, Chase Douglas wrote:
> This allows the latest N-Trig devices to function properly.
>
> BugLink: https://bugs.launchpad.net/bugs/724831
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Chase Douglas<chase.douglas at canonical.com>
> Signed-off-by: Jiri Kosina<jkosina at suse.cz>
> ---
> This has been accepted into Jiri Kosina's git tree for 3.4. It will eventually
> come down through the stable queue in three or four months, but it should be
> applied to Precise in the meantime.
>

Surely you mean the 3.3 merge window ? Why won't Jiri accept this for 
3.2 ? There are still a number of rc candidates left, and this looks 
like a minor bug fix patch suitable for an rc.

> Note that this won't have any effect until the Ubuntu sauce hid-ntrig patches
> are reverted.
>
>   drivers/hid/hid-core.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 4f81d20..1691c99 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -361,7 +361,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item)
>
>   	case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
>   		parser->global.report_size = item_udata(item);
> -		if (parser->global.report_size>  32) {
> +		if (parser->global.report_size>  96) {
>   			dbg_hid("invalid report_size %d\n",
>   					parser->global.report_size);
>   			return -1;


-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list