[Maverick SRU][PATCH 0/2] Enable volume hot keys on Dell All-In-One with broken firmware.
tcanonical at tpi.com
Tue Jan 11 23:46:47 UTC 2011
On 01/11/2011 05:27 PM, Tim Gardner wrote:
> On 01/11/2011 10:42 AM, Colin King wrote:
>> From: Colin Ian King<colin.king at canonical.com>
>> Enable WMI hotkeys on event GUID 02314822-307C-4F66-bf0E-48AEAEB26CC8.
>> enables the volume up and down keys. This Dell All-In-One enablement also
>> has to work around a firmware implementation bug where the WMI _WED
>> should return an integer containing the key code and in fact the method
>> incorrectly returns the key code in element zero of a buffer.
>> The second patch in this series tidies up the driver by removing a lot of
>> redundant code by using sparse keymaps.
>> BugLink: http://bugs.launchpad.net/bugs/701530
>> Impact: Dell device is lacking volume up/down hotkeys which require
>> a WMI driver to handle the WMI hotkey events with the GUID
>> Fix: Update dell WMI driver to support GUID
>> and handle firmware bug in _WED method return value.
>> Testcase: With the driver, hotkeys work correctly. Without the driver,
>> hotkeys don't work.
>> Colin Ian King (2):
>> UBUNTU: SAUCE: Add WMI hotkeys support for another Dell All-In-One
>> UBUNTU: SAUCE: Dell WMI: Use sparse keymaps and tidy up code.
>> drivers/platform/x86/dell-wmi-aio.c | 182
>> 1 files changed, 67 insertions(+), 115 deletions(-)
> So, I'm not too wild about this patch set. While I'm sure its correct
> (and should go upstream), its a substantial patch and will likely make
> our future maintenance efforts much more difficult since this diverges
> substantially from upstream. How difficult would it be to support this
> via an LBM package or DKMS ?
> Is there anyway to write a minimally invasive patch that provides the
> same functionality?
Never mind, I was thinking this was the generic Dell WMI platform driver.
Acked-by: Tim Gardner <tim.gardner at canonical.com>
with the provision that this get regression tested on the original GUID.
Tim Gardner tim.gardner at canonical.com
More information about the kernel-team